Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: improve batch query #1371

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 257 BBG.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c4f1af0) 20.99% compared to head (1448c05) 20.99%.
Report is 483 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   20.99%   20.99%           
=======================================
  Files         568      567    -1     
  Lines       40623    40627    +4     
=======================================
+ Hits         8529     8531    +2     
- Misses      31463    31465    +2     
  Partials      631      631           
Files Coverage Δ
pkg/types/exchange.go 0.00% <ø> (ø)
pkg/exchange/batch/trade.go 78.78% <50.00%> (+1.36%) ⬆️
pkg/exchange/bybit/exchange.go 0.00% <0.00%> (ø)
pkg/exchange/batch/closedorders.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f1af0...1448c05. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 271 BBG

@bailantaotao
Copy link
Collaborator Author

added more comments in bybti func

@c9s
Copy link
Owner

c9s commented Nov 17, 2023

do you want to merge this?

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants