Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [indicator] adding a bunch of new v2 indicators #1366

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

go-dockly
Copy link

No description provided.

@bbgokarma-bot
Copy link

Hi @go-dockly,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 4869 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 9820 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 9931 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 10340 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 10633 BBG

@c9s c9s changed the title feat/indicators adding a bunch of new v2 indicators FEATURE: [indicator] adding a bunch of new v2 indicators Oct 28, 2023
pkg/bbgo/indicator_set.go Outdated Show resolved Hide resolved
pkg/datatype/floats/slice.go Outdated Show resolved Hide resolved
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 11162 BBG

@c9s
Copy link
Owner

c9s commented Oct 30, 2023

this PR is getting too big to merge, would you mind to split them and maybe we can merge some changes, like the csv source package, and the kline csv readers, or maybe the extended slice methods.

pkg/indicator/v2/bst/bst.go Outdated Show resolved Hide resolved
pkg/indicator/v2/bst/bst.go Outdated Show resolved Hide resolved
pkg/bbgo/indicator_set.go Outdated Show resolved Hide resolved
@c9s c9s added the indicator label Oct 30, 2023
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 11026 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 11031 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 11650 BBG

@c9s
Copy link
Owner

c9s commented Nov 2, 2023

There are too many files, like 140+ files that I could not review all files in one round, will continue the review later.

Since you're the first-time contributor, it would be nice if you can submit a pull request with a small change, so that the CI could be executed for your later PRs.

@c9s
Copy link
Owner

c9s commented Nov 2, 2023

Or, maybe you can pull out the csvsource changes to one PR, I've reviewed these csvsource file changes.

pkg/indicator/v2/bollinger_band.go Outdated Show resolved Hide resolved
pkg/indicator/v2/bollinger_band_test.go Show resolved Hide resolved
pkg/indicator/v2/breakaway.go Outdated Show resolved Hide resolved
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8952 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8224 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8229 BBG

@go-dockly
Copy link
Author

This build is failing due to the go.mod specified compiler v1.18.
Can we bump to latest go please?

@c9s
Copy link
Owner

c9s commented Nov 3, 2023 via email

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8364 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8369 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8379 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 8399 BBG

@go-dockly
Copy link
Author

I think this PR is good to merge now

@c9s
Copy link
Owner

c9s commented Dec 8, 2023

@go-dockly could you please rebase the commits? make it no merge-commits in your PR, thanks

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants