Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons outside #22

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Buttons outside #22

wants to merge 4 commits into from

Conversation

danogh
Copy link

@danogh danogh commented Oct 5, 2020

This pushes the buttons to the outside edge when using the bottom panel.

I believe that this addresses issue #16. It also makes it more intuitive when using centered tasks.

@danogh
Copy link
Author

danogh commented Oct 13, 2020

This actually does not address issues #16. It does put the buttons and the edge of the screen for the bottom panel. This prevents the buttons from moving around as the number of open windows changes.

Any thoughts?

@danogh
Copy link
Author

danogh commented Oct 14, 2020

I noticed while looking into issue #16 that if I turn off the Tasks while using the bottom bar that all the buttons end up on the far left. The only reason I can think of for having a bottom panel without tasks is to show the favorites. I can think of several ways to fix that:

  • Use where the Tasks would go as a placeholder for what buttons go to the far right.
  • Put everything in boxMain when Tasks is off.
  • Put the Favorites in boxMain when Tasks is off. Do one of the two previous things if both Tasks and Favorites are off.
  • Add additional configuration options to control pushing buttons to the outer edges. There are already a lot of options. I'm not sure what option setting(s) would be the most intuitive. I can think of several ideas for possible options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant