Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip theory #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Strip theory #26

wants to merge 4 commits into from

Conversation

atagg2
Copy link
Collaborator

@atagg2 atagg2 commented Mar 26, 2022

Addition of strip theory to calculate viscous drag

@andrewning andrewning self-requested a review September 21, 2022 19:21
@andrewning
Copy link
Member

andrewning commented Sep 21, 2022

  • the example won’t work as is. you have an input parameter res that is not provided (the list of Reynolds number corresponding to the provided data).
  • You should also generate the figure in the docs on the fly so you can ensure that the code you provide is actually running what you expect (in this case it'll throw an error and we'd want to catch that). I'd need you to provide the data in this case since it's not here in the code for the figure to be re-generated.
  • strip_theory_drag! is hard coded to the first surface.
  • this assumes that the same airfoil ls used throughout the surface, and on every surface. would need to specify those per section like twist or other airfoil variables.
    @atagg2 @rymanderson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants