Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init search logs tutorial #454

Closed
wants to merge 14 commits into from
Closed

init search logs tutorial #454

wants to merge 14 commits into from

Conversation

lfunderburk
Copy link
Contributor

Initialize migration of guides into docs

Copy link

codspeed-hq bot commented May 1, 2024

CodSpeed Performance Report

Merging #454 will not alter performance

Comparing search-logs-guide (ce25b22) with main (e65e5b3)

Summary

✅ 6 untouched benchmarks

Copy link
Contributor

@whoahbot whoahbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together and fixing the docs for cbfmt.

docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
Copy link
Contributor

@davidselassie davidselassie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these. I have a bevvy of small formatting suggestions to make it match the rest of the docs. I know you're going to be refactoring this to use a single dataflow file, but I think some of the text formatting comments here are still worthwhile. Thanks!

docs/index.md Outdated Show resolved Hide resolved
docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
# run dataflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should include an explicit run script and I would delete this file. It'd be the same for every demo and folks will need to know how to run their own dataflows. I think it makes more sense to xlink to the https://docs.bytewax.io/stable/guide/concepts/workers-parallelization.html#specifying-the-dataflow existing docs when we need to mention how to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved 519b773

docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/tutorial/search-logs/dataflow.py Outdated Show resolved Hide resolved
docs/tutorial/search-logs/search-logs-tutorial.md Outdated Show resolved Hide resolved
lfunderburk and others added 14 commits May 14, 2024 15:06
Co-authored-by: Dan Herrera <whoahbot@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io>
Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
@lfunderburk
Copy link
Contributor Author

closing and restarting new branch from main with current changes

@lfunderburk lfunderburk deleted the search-logs-guide branch May 14, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants