-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init search logs tutorial #454
Conversation
CodSpeed Performance ReportMerging #454 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together and fixing the docs for cbfmt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these. I have a bevvy of small formatting suggestions to make it match the rest of the docs. I know you're going to be refactoring this to use a single dataflow file, but I think some of the text formatting comments here are still worthwhile. Thanks!
docs/tutorial/search-logs/run.sh
Outdated
@@ -0,0 +1,2 @@ | |||
# run dataflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should include an explicit run script and I would delete this file. It'd be the same for every demo and folks will need to know how to run their own dataflows. I think it makes more sense to xlink to the https://docs.bytewax.io/stable/guide/concepts/workers-parallelization.html#specifying-the-dataflow existing docs when we need to mention how to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved 519b773
Co-authored-by: Dan Herrera <whoahbot@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Laura Gutierrez Funderburk <lfunderburk@users.noreply.github.com>
ce25b22
to
0001121
Compare
closing and restarting new branch from main with current changes |
Initialize migration of guides into docs