add SyncBatchNorm #387
Open
add SyncBatchNorm #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add byteps.torch.SyncBatchNorm - add BYTEPS_SYNC_BN_GLOBAL to choose between global sync and node local sync. defaults to node local sync - add node local allgather Signed-off-by: yulu.jia <yulu.jia@bytedance.com>
ymjiang
reviewed
Apr 18, 2021
tests/test_bps_torch_syncbn.py
Outdated
| skip_or_fail_gpu_test(self, "No GPUs available") | ||
|
|
||
| def test_horovod_sync_batch_norm(self): | ||
| print("xxx starting the test") |
There was a problem hiding this comment.
Shall we remove this or make it more formal?
ymjiang
reviewed
Apr 18, 2021
tests/test_bps_torch_syncbn.py
Outdated
|
|
||
| bps.init() | ||
| torch.cuda.set_device(bps.local_rank()) | ||
| print("xxx my local rank is ", bps.rank()) |
|
For future reference: https://github.com/facebookresearch/fairscale/pull/662/files |
|
|
||
| Arguments: | ||
| tensor: A tensor to allgather. | ||
| name: A name of the allgather operation. |
There was a problem hiding this comment.
document node_local?
- add byteps.torch.SyncBatchNorm - add BYTEPS_SYNC_BN_GLOBAL to choose between global sync and node local sync. defaults to node local sync - add node local allgather Signed-off-by: yulu.jia <yulu.jia@bytedance.com> Signed-off-by: Yulu Jia <yulu.jia@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yulu.jia yulu.jia@bytedance.com