Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-masking): add ui for inner and outer maskers #12000

Merged

Conversation

Azusain
Copy link
Contributor

@Azusain Azusain commented May 15, 2024

No description provided.

@Azusain
Copy link
Contributor Author

Azusain commented May 15, 2024

Current UI:
demo

Copy link
Collaborator

@ecmadao ecmadao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Copy link
Collaborator

@ecmadao ecmadao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget to remind add disabled props for NRadioGroup…

@Azusain Azusain requested a review from ecmadao May 15, 2024 10:02
Copy link
Contributor

@LiuJi-Jim LiuJi-Jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall
some nits

…thmsCreateDrawer.vue

Co-authored-by: Liu Ji <2749742+LiuJi-Jim@users.noreply.github.com>
@Azusain Azusain enabled auto-merge (squash) May 15, 2024 10:47
@Azusain Azusain merged commit 84d4096 into bytebase:main May 15, 2024
15 checks passed
@Azusain Azusain deleted the tommy/byt-4499-support-mask_inner-and-mask_outer branch May 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants