Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sql-review): new rule for OceanBase (MySQL mode) offline ddl #11997

Merged
merged 2 commits into from
May 16, 2024
Merged

feat(sql-review): new rule for OceanBase (MySQL mode) offline ddl #11997

merged 2 commits into from
May 16, 2024
+300 −4

Conversation

whhe
Copy link
Contributor

@whhe whhe commented May 15, 2024 •
edited

This advisor checks following operations:

  • add/modify to auto increment columns
  • add/drop primary keys
  • add/drop stored generated columns
  • chang charset or collate
  • truncate/dropp tables
  • modify/drop/truncate partitions

ref https://www.oceanbase.com/docs/common-oceanbase-database-cn-1000000000252799

@cla-bot cla-bot bot added the cla-signed label May 15, 2024
rebelice
rebelice approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@rebelice rebelice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, otherwise

backend/server/minimal_demo.go Outdated Show resolved Hide resolved
@rebelice
Copy link
Contributor

Looks like you need to resolve the conflicts ovo @whhe

@d-bytebase d-bytebase merged commit b0bd091 into bytebase:main May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@LiuJi-Jim LiuJi-Jim Awaiting requested review from LiuJi-Jim LiuJi-Jim is a code owner

@boojack boojack Awaiting requested review from boojack boojack is a code owner

@h3n4l h3n4l Awaiting requested review from h3n4l h3n4l is a code owner

@d-bytebase d-bytebase Awaiting requested review from d-bytebase d-bytebase is a code owner

@ecmadao ecmadao Awaiting requested review from ecmadao ecmadao is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whhe @rebelice @d-bytebase