-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-masking): add ui for inner and outer maskers #12000
feat(data-masking): add ui for inner and outer maskers #12000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
frontend/src/components/SensitiveData/components/MaskingAlgorithmsCreateDrawer.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forget to remind add disabled props for NRadioGroup…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
some nits
frontend/src/components/SensitiveData/components/MaskingAlgorithmsCreateDrawer.vue
Outdated
Show resolved
Hide resolved
…thmsCreateDrawer.vue Co-authored-by: Liu Ji <2749742+LiuJi-Jim@users.noreply.github.com>
No description provided.