Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/react native share #79

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Test/react native share #79

wants to merge 2 commits into from

Conversation

byCedric
Copy link
Owner

@byCedric byCedric commented Jan 13, 2023

Linked issue

Testing react-native-share in a pnpm monorepo because of this tweet.

Additional context

Want to try it out yourself?

  • Clone the repository, go to root
  • $ pnpm install
  • $ pnpm build
  • $ cd apps/mobile
  • $ npx expo run:android|ios

EAS also seems to work: https://github.com/byCedric/expo-monorepo-example/actions/runs/3915548238/jobs/6693833419

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
expo-monorepo-example ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 10:52PM (UTC)

@github-actions
Copy link

This pull request was automatically deployed using Expo GitHub Actions!

  • Project: @bycedric/expo-monorepo
  • Channel: pr-79

@byCedric
Copy link
Owner Author

image

Seems to be working fine

@byCedric
Copy link
Owner Author

@rodolphoasb
Copy link

rodolphoasb commented Jan 14, 2023

@byCedric, I'm still getting this error (even after have used the patch):

image

Any ideas about what could be causing this?

Complete error message here: https://gist.github.com/rodolphoasb/2fcb8b8a7e01b9b4fcc51b9b94c2fb60

My eas.json:

{
  "cli": {
    "promptToConfigurePushNotifications": false
  },
  "build": {
    "monorepo": {
      "cache": {
        "key": "turbo",
        "customPaths": ["../../node_modules/.cache/turbo"]
      }
    },
    "development": {
      "extends": "monorepo",
      "developmentClient": true,
      "distribution": "internal"
    },
    "sim-dev": {
      "extends": "development",
      "ios": {
        "simulator": true,
        "resourceClass": "m1-medium"
      }
    },
    "preview": {
      "distribution": "internal"
    },
    "production": {
      "ios": {
        "resourceClass": "m1-medium"
      }
    }
  },
  "submit": {
    "production": {}
  }
}

What I'm running:
eas build -p ios --profile sim-dev

@byCedric
Copy link
Owner Author

byCedric commented Jan 14, 2023

Can you share a repo of your monorepo? It doesn't need to contain the app (e.g. drop all contents of the app, but keep the basic expo code), I'm more interested in the "skeleton" of the repository, e.g. where certain libraries are installed by pnpm. @rodolphoasb

@rodolphoasb
Copy link

rodolphoasb commented Jan 16, 2023

@byCedric, Here's a very similar repo structure where the error is also happening: https://github.com/mercado-rural/technobody

Command that I'm running: eas build -p ios --profile development.

Error:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants