Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use high-resolution clock when computing lastEventTime #889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmnielsen
Copy link

This is a very simple PR intended to address the timer resolution issue discussed on #860.

I created the PR against the main branch since I think it makes sense to patch this in BWAPI 4.X, seeing as how timeouts continue to be an issue in tournaments held since the issue was raised.

@bwapi-build
Copy link

Build bwapi 4.4.0.403 completed (commit 8283b22dee by @bmnielsen)

@N00byEdge
Copy link
Member

Can you rebase on develop?

@bmnielsen
Copy link
Author

Can you rebase on develop?

Isn't that where BWAPI 5 development is happening? As far as I can tell, lastEventTime hasn't been implemented yet there (the field is in the protobuf spec and available through getters, but doesn't appear to be set anywhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants