Extract mongo version to interface #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is relevant if the values are processed in other expressions.
bwaldvogel
requested changes
Mar 18, 2024
rgruber1
force-pushed
the
hellcat-version-interface
branch
from
dad40a0
to
f087541
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 95.22% 95.22%
Complexity 3291 3291
=========================================
Files 183 184 +1
Lines 14112 14112
Branches 1326 1326
=========================================
Hits 13438 13438
Misses 446 446
Partials 228 228 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
No thank you Benedikt and hellproxy! |
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggyback's hellcat's original fork and PR albeit with Benedikt's PR feedback applied.
This change allows mongo-java-server clients to specify the MongoVersion.
Use case example: where MongoDB features such as commit quorum require a min MongoDB version (of 4.4) in mongodb-driver-core.