Merge pull request #223 from elangoravi/main

Fix: serverStatus command to execute in both admin and non-admin db(s)
bwaldvogel · Mar 19, 2024 · 11de691 · 11de691
2 parents a6c1f22 + 2f421bb
commit 11de691
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoBackend.java b/core/src/main/java/de/bwaldvogel/mongo/backend/AbstractMongoBackend.java
@@ -198,8 +198,6 @@ private Document handleAdminCommand(String command, Document query) {
             return handleGetCmdLineOpts();
         } else if (command.equalsIgnoreCase("getFreeMonitoringStatus")) {
             return handleGetFreeMonitoringStatus();
-        } else if (command.equalsIgnoreCase("serverStatus")) {
-            return getServerStatus();
         } else if (command.equalsIgnoreCase("endSessions")) {
             log.debug("endSessions on admin database");
             return successResponse();
@@ -332,6 +330,8 @@ public Document handleCommand(Channel channel, String databaseName, String comma
             return handleKillCursors(query);
         } else if (command.equalsIgnoreCase("ping")) {
             return successResponse();
+        } else if (command.equalsIgnoreCase("serverStatus")) {
+            return getServerStatus();
         } else if (databaseName.equals(ADMIN_DB_NAME)) {
             return handleAdminCommand(command, query);
         }

diff --git a/test-common/src/main/java/de/bwaldvogel/mongo/backend/AbstractBackendTest.java b/test-common/src/main/java/de/bwaldvogel/mongo/backend/AbstractBackendTest.java
@@ -2468,7 +2468,11 @@ private static String repeat(String str, int num) {
 
     @Test
     public void testServerStatus() throws Exception {
-        Document serverStatus = runCommand("serverStatus");
+        verifyServerStatus(runCommand("serverStatus"));
+        verifyServerStatus(getDatabase().runCommand(json("serverStatus:1")));
+    }
+
+    private void verifyServerStatus(Document serverStatus) {
         assertThat(serverStatus.getDouble("ok")).isEqualTo(1);
         assertThat(serverStatus.get("uptime")).isInstanceOf(Number.class);
         assertThat(serverStatus.get("uptimeMillis")).isInstanceOf(Long.class);

diff --git a/test-common/src/test/java/de/bwaldvogel/mongo/RealMongoBackendTest.java b/test-common/src/test/java/de/bwaldvogel/mongo/RealMongoBackendTest.java
@@ -115,7 +115,11 @@ public void testQueryWithSubdocumentIndex() throws Exception {
     @Test
     @Override
     public void testServerStatus() throws Exception {
-        Document serverStatus = runCommand("serverStatus");
+        verifyServerStatus(runCommand("serverStatus"));
+        verifyServerStatus(db.runCommand(json("serverStatus:1")));
+    }
+
+    private void verifyServerStatus(Document serverStatus) {
         assertThat(serverStatus.getDouble("ok")).isEqualTo(1);
         assertThat(serverStatus.get("uptime")).isInstanceOf(Number.class);
         assertThat(serverStatus.get("uptimeMillis")).isInstanceOf(Long.class);