i18n

[ph1p]

Hi!

This PR adds i18n functionality and is currently WIP. I'll add auto detection and a language chooser or something else.
I have copied some code from buttercup-desktop and experimented a little (:

I am pleased about your thoughts and suggestions.

[UPDATE]

• Autodetection

[julianpoemp]

That's what I was looking for 😁👍

[perry-mitchell]

Great stuff @ph1p! This'd be super handy.

[ph1p]

I'm almost done translating all the strings. Some parts are a bit confusing (sheets.js), but it should work (: Currently I have added English and German. Buttercup auto detects the language.

[perry-mitchell]

Great @ph1p! Amazing work. Should we give it an in-depth review now? Would you say the WIP is done?

[ph1p]

Sure! Feel free to review. I know there's definitely room for improvement, but it's a first version (:

[ph1p]

I also tried to fix the build bugs. I made android work, but ios still fails.

Found this config: https://travis-ci.org/ankidroid/Anki-Android/builds/526250449/config

[sallar]

This is lovely! Thank you

[perry-mitchell]

Looks good to me. I can do some testing on this tomorrow. I'll leave it to @sallar to make a review as well.

[perry-mitchell]

Apologies @ph1p once again for missing this - I'll try to handle the conflicts so you don't need to again. We upgrade react-navigation to get the OTP codes feature working, so I'll skip that in this MR.

[perry-mitchell]

Hi @ph1p - I've merged your branch with master over at #209 and it seems to work locally. There's now a few missing localisations as we added text in the OTP codes MR. There's also the error messages and some other pieces of text (eg. "OK") which need localising, but that should be quite easy I guess.

I did remove the changes for the react-navigation upgrade as we'd done the same, sorry, and had also removed the redux portion of it (as we were originally planning to do away with it anyway). I'm sorry if you spent any great amount of time on this.

Now the final part: What would you like to do? Should we take it from here and finish it off, or would you prefer to take the merge-commit into your branch and finalise it yourself? We're entirely happy either way.. just sorry that we left it sit for so long.

Thanks for the help and patience :)

[ph1p]

Hi @ph1p - I've merged your branch with master over at #209 and it seems to work locally. There's now a few missing localisations as we added text in the OTP codes MR. There's also the error messages and some other pieces of text (eg. "OK") which need localising, but that should be quite easy I guess.

I did remove the changes for the react-navigation upgrade as we'd done the same, sorry, and had also removed the redux portion of it (as we were originally planning to do away with it anyway). I'm sorry if you spent any great amount of time on this.

Now the final part: What would you like to do? Should we take it from here and finish it off, or would you prefer to take the merge-commit into your branch and finalise it yourself? We're entirely happy either way.. just sorry that we left it sit for so long.

Thanks for the help and patience :)

Hi @perry-mitchell,
That was a long way, until now :D

I did remove the changes for the react-navigation upgrade as we'd done the same, sorry, and had also removed the redux portion of it (as we were originally planning to do away with it anyway). I'm sorry if you spent any great amount of time on this.

That's all right. It's your project and I see a PR more as a proposal and discussion basis to get the best out of it. And if just everything is merged without meaning, nobody is helped (:

Now the final part: What would you like to do? Should we take it from here and finish it off, or would you prefer to take the merge-commit into your branch and finalise it yourself? We're entirely happy either way.. just sorry that we left it sit for so long.

I can do it gladly. I want to help you and finish it in the next days ;)
Should I create a new PR and we close this one or should I override this?

[EDIT]:
nevermind, I force pushed it to this one.

[ph1p]

@perry-mitchell I think I'm done.
Let me know if something is missing or if I have to adjust the structure of the locale files.

[sallar]

Amazing work @ph1p as always. I just have one question, then I can approve and merge

[perry-mitchell]

Couple of changes! Otherwise this looks epic.. :D

[perry-mitchell]

Thanks @ph1p - Taking this forward to another branch so we can merge it with our rn upgrade and get it out! Great work on this!