Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.table backend for tk_augment_lags #102 #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlbertoAlmuinha
Copy link

Hi @mdancho84 ,

I just updated the tk_augment_lag and tk_augment_lead functions so they work with data.table and tidytable behind. I think that with the changes made, both functions should be much faster because they are practically already written with functions that call C code. As a good practice, I think I would try to change the rest of the functions little by little to try to introduce tidytable as much as possible because it already has a large number of supported functions (all map family, dplyr verbs, tidyr family...). I have been very impressed with this package really.

Regards,

@mdancho84
Copy link
Contributor

Excellent!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants