data.table backend for tk_augment_lags #102 #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mdancho84 ,
I just updated the
tk_augment_lag
andtk_augment_lead
functions so they work with data.table and tidytable behind. I think that with the changes made, both functions should be much faster because they are practically already written with functions that call C code. As a good practice, I think I would try to change the rest of the functions little by little to try to introducetidytable
as much as possible because it already has a large number of supported functions (all map family, dplyr verbs, tidyr family...). I have been very impressed with this package really.Regards,