Sending github error status on unhandled errors + Adding max timeout #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olves bundlewatch APIs and other opaque side-effects so that we can (hopefully always) fail the action when unhandled errors happen, rather than have it hang forever.
Pull Request Test Coverage Report for Build 98e8a1b4-e61b-420b-b796-5fdc75de6164
💛 - Coveralls |
…n handlers, adding property to github service class for it so we know if it has never responded to github, and if not we can throw an error
bigbizze
changed the title
…tatus to github when the value for maxTimeout is reached. This also helps prevent the infinite hanging issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #456, I moved the github service initialization outside of code context that involves bundlewatch APIs and other opaque side-effects laden things, so that it can (hopefully always) fail the action when unhandled errors happen, rather than never reporting a status to github like was frequently happening (as per the mentioned issue)
I also added a maxTimeout config option.
bugfix
Does this PR introduce a breaking change?
No