Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mjs and cjs extensions #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EdieLemoine
Copy link

What kind of change does this PR introduce?

A feature.

Did you add tests for your changes?

No. There don't seem to be relevant tests for this yet.

If relevant, link to documentation update:

N/A

Summary

When passing a cjs or mjs file to the --config parameter, BundleWatch treats it as JSON because it only treats .js as JavaScript, and everything else as JSON.

Does this PR introduce a breaking change?

No.

Other information

N/A

EdieLemoine added a commit to myparcelnl/js-pdk that referenced this pull request Feb 21, 2023
@quantizor
Copy link

@charpeni could you take this change please? It's very hard to use this project in a "type": "module" downstream repo.

@charpeni
Copy link
Member

Will have a look shortly in the next few days to merge pending pull requests and get a new release out, thanks for the ping and I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants