fix: ignore directories from glob matching #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current glob.sync can match directories as well as files, which will then fail when trying to get the size of the file, this change ignores directories when performing the glob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current glob.sync can match directories as well as files, which will then fail when trying to get the size of the file, this change ignores directories when performing the glob.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Could not find any unit tests in the codebase, am I missing something?
If relevant, link to documentation update:
Summary
The current glob match will match directories that match your file globs, eg. a files entry of .nuxt/dist/client/**/*.css
will match a file named .nuxt/dist/client/2.css/23r23.css
but also a directory named `.nuxt/dist/client/2.css`` and will thus fail on this dir.
This change skips any directory that matches the provided glob.
Does this PR introduce a breaking change?
Not as far as I'm aware
Other information
Couldn't find a great way to test this so could use some help validating that this change works as intended...