Build as proper NPM module #7
Draft
+1,498
−480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure according to the guide here: https://pauloe-me.medium.com/typescript-npm-package-publishing-a-beginners-guide-40b95908e69c
rexgarland
commented
May 15, 2024
index.js
Outdated
There was a problem hiding this comment.
(With small changes due to the import ./types)
rexgarland
commented
May 15, 2024
There was a problem hiding this comment.
This whole file was reindented due to Prettier. I believe this is a more stable formatting going forward, but the diff will be ugly.
rexgarland
commented
May 15, 2024
Comment on lines
+4
to
+9
| "main": "./dist/index.js", | ||
| "module": "./dist/index.mjs", | ||
| "types": "./dist/index.d.ts", | ||
| "files": [ | ||
| "dist" | ||
| ], |
rexgarland
commented
May 15, 2024
| "build": "yarn build:module && yarn build:symbol && yarn build:package", | ||
| "build:module": "npx pegjs -o src/module-parser.js --allowed-start-rules module,board ./src/module.pegjs", | ||
| "build:symbol": "npx pegjs -o src/symbol-parser.js --allowed-start-rules kicad_symbol_lib ./src/symbol.pegjs", | ||
| "build:package": "tsup", |
rexgarland
commented
May 15, 2024
src/utils.js
Outdated
There was a problem hiding this comment.
No-op change due to reruning tsc. Next step would be to not check this file in at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Testing
test/TODO:
pnpm build:copilotworks on in fluxNotes
flux-app, since we're referencing this module by exact commits already, not pointing to HEAD here.