Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 176 and 629: Process extends in order #644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

distributist
Copy link

@distributist distributist commented Jan 29, 2024

Process extends in order, otherwise variable settings can be applied out of order.
Fixes #176
Fixes #629.

I first submitted this patch almost 10 years ago. We run a very complex buildout, and this breaks it. I've been patching buildout 2, for almost 10 years, with no issues. The application of this patch to buildout 3 was very straightforward. I believe this fix is stable, and would really appreciate seeing it incorporated.

Thank you.

@icemac
Copy link

icemac commented Feb 2, 2024

O no: Ran 616 tests with 15 failures – these are probably failures on master not in your PR.

It seems we need a volunteer to fix the tests on master first.

@distributist
Copy link
Author

I spent a couple of hours looking into the tests, and I think it's a CI configuration issue. The tests run fine when I check out buildout and run them locally.

The failing tests follow the same pattern:

File "/home/runner/work/buildout/buildout/src/zc/buildout/tests/repeatable.txt", line 118, in repeatable.txt
Failed example:
    print_(system(buildout), end='')
Expected:
    Getting distribution for 'spam==1'.
    Got spam 1.
    Uninstalling foo.
    Installing foo.
    recipe v1
Got:
    root: root: root: Couldn't retrieve index page for 'spam'
    root: Scanning index of all packages (this may take a while)
    Getting distribution for 'spam==1'.
    Got spam 1.
    Uninstalling foo.
    Installing foo.
    recipe v1

What is causing the test to "fail" is the additional scan for the package(s), as if it's using the wrong location or URL.

I poked around a bit, but unfortunately I don't know Github or the CI system, so I'm not sure where the issue lies. I hope this information helps someone in tracking it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parts += bug with multiple extends extends with increments can result in missing values
2 participants