Fix urlretrieve for python3, support basic auth #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dout cfg downloads Fix python 3 urlretrieve for downloading external config files with basic auth in the URL. Same as issue buildout#257 for python 2 in release 2.5.1.
|
The tests are failing because of an endless loop of buildout update dependencies with python 3. I Guess this is fixed in pull request #536. Can someone confirm that. Is it possible to get commit/write access to this repository. I'm a zopefoundation member. |
|
@projekt01 Hi Roger, I sent you an invitation to become a developer in the buildout organization. |
|
@projekt01 Would you rebase on master to check if CI pass ? |
gotcha
force-pushed
the
master
branch
2 times, most recently
from
b8ad13b
to
5db2e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3, Basic Authentication support. This is used for downloads from private pypi server e.g.
buildout -c https://pypi.foobar.com/private/something.cfg
Same issue as #257 for python 2 in release 2.5.1.