handle when you combine increments without a base equals #177
Conversation
|
@tseaver @jimfulton Hoping this fix is suitable? |
|
I'm not really up on the guts of the '+=' implementation, but the test looks like it illustrates the problem clearly, and I can kind of see how your fix works. I'll let @jimfulton have a crack at commenting / merging: bug me in a couple of days if the issue hasn't moved forward. |
|
ping @jimfulton, @tseaver if you have time look over this change I'd really appreciate it. |
|
@jimfulton @tseaver still keen to get an answer if this can be merged. |
|
@mgedmin @jimfulton @tseaver I'm pretty happy with this pull request. Can I just merge it? |
|
@djay OK by me to merge. |
|
@tseaver actually forgot I don't have permission to merge it on this repo. Can someone merge for me please? @mgedmin @jimfulton |
| @@ -10,6 +10,9 @@ Unreleased | |||
| - Add ``BUILDOUT_HOME`` as an alternate way to control how the user default | |||
| configuration is found. | |||
|
|
|||
| - Fix edgecase where using multiple inheritance and increments can result in | |||
| some increments not being included in the final value | |||
There was a problem hiding this comment.
"Edge case" is two words.
Other changelog entries end with a final period, perhaps it would be good to follow that convention.
It would also be good to link to a bug report.
|
I tried to do some code review. I'm not comfortable merging this at this point (see my line comments). Also, merge conflicts. It would be nice if you could resolve them, @djay. I'm not sure what the best approach is: rebasing and force-pushing (I'm leaning towards it) or merging master into your branch and pushing. |
gotcha
force-pushed
the
master
branch
2 times, most recently
from
b8ad13b
to
5db2e99
Compare
This bug can result in not all values in your increments making it into the final value. Fixes issue #176