Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurator #784

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Configurator #784

wants to merge 44 commits into from

Conversation

veej
Copy link
Member

@veej veej commented Sep 25, 2023

Screen.Recording.2023-09-25.at.18.02.07.mov

Comment on lines 89 to 95
<SliderField
type="single"
label={unsafeLocalizedString("")}
value={50}
minValue={0}
maxValue={100}
onChange={() => {}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but I would add a valid onChange here. I've tried interacting with it and it felt "broken"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants