Module add #166
Open
Module add #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2016 15:57
|
Two PR's in one day! 🎉 I think what we decide on #165 will end up affecting this one, so let's think about them together over there. |
| elif not params.args['<url>']: | ||
| params.runtime.display.print('Please specify a module url. See usage with peru module --help') | ||
| elif not params.args['<type>']: | ||
| params.runtime.display.print('Please specify a module type. See usage with peru module --help') |
There was a problem hiding this comment.
Instead of doing all the work to check required fields in code, just make them required in the docopt string above, by removing the surrounding [ ] braces. Docopt is really nice for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again! I was wondering if you'd be interested in integrating some sort of
peru module addcommand that would allow users to add modules from the command line. My company would find this useful for automating some build tasks using Peru. Let me know what you think! Thanks!