Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt to deflake arm64 tests #6552

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented May 10, 2024

  • Reduce the effective --local_test_jobs from 16 to 8 - seems like remote_execution_test keeps crashing due to running too many jobs locally. We're already setting size = "enormous" so I'm not sure there's anything else we can do to reduce the local test concurrency, short of setting tags = ["exclusive"] which we don't really want since the individual test shards take kind of a long time :/
  • Increase flaky_test_attempts from 2 to 3
  • Remove cpu:4 tag - I found this on stackoverflow or something a while back, but when testing it out it doesn't seem like it actually does anything in this case. In the timing profile, I was seeing 16 test actions running concurrently which wouldn't make sense if this actually worked, since the arm64 runner only has 16 cores.

Related issues: N/A

@bduffany bduffany merged commit 15ade38 into master May 13, 2024
18 checks passed
@bduffany bduffany deleted the deflake-arm64-again branch May 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants