Restrict group_id label cardinality #6537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
changed the title
|
This would break the prober latency graph, need to think of how to keep that working. |
bduffany
force-pushed
the
rm-group-id
branch
2 times, most recently
from
3e75a10
to
99dafed
Compare
bduffany
changed the title
bduffany
changed the title
vadimberezniker
approved these changes
May 10, 2024
|
|
||
| // GroupIDLabel returns a value suitable for use with the GroupID label. It | ||
| // restricts the observed group IDs to the allowed values configured by flag. | ||
| func GroupIDLabel(groupID string) string { |
There was a problem hiding this comment.
Can we call this FilteredGroupIDLabel? There will still be cases where we will want unfiltered group IDs on metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Action stage durations" chart cardinality is too high and makes it slow to load. A single query loads over 300K individual timeseries from the DB.
Restricting to just prober group IDs should fix this (we want to split out prober latency to keep the prober latency chart working). If we need to query by other group IDs, we can use Clickhouse instead.
Related issues: N/A