dirtools: fix handling symlink inside output dir #6536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add some tests to better catch these cases in the future. |
Previously we were verifying the outputs inside ActionResult against the mock data we created on disk. Change to verify them against the outputs declared in the Action.Command.
sluongng
force-pushed
the
sluongng/dirtools-fix
branch
from
f540bce
to
6f6676d
Compare
Verify that we properly handle the symlink in output directory.
sluongng
force-pushed
the
sluongng/dirtools-fix
branch
from
6f6676d
to
838ec88
Compare
bduffany
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
dirHelper.IsOutputPathtodirHelper.ShouldUploadFileto detect cases where the symlink was not explicitly declared as a command output, but a parent directory was.Move this check outside of the
ifclause as we need to do this regardless of REAPI protocol version.Use only the symlink file name instead of the full path as when we add the symlink to its parent directory.
Closes https://github.com/buildbuddy-io/buildbuddy-internal/issues/3347