Implement placement driver to add and replace dead replicas #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luluz66
added a commit
that referenced
this pull request
May 7, 2024
In replica.Replica, rename ShardID -> shardID and ReplicaID -> replicaID. In placement driver PR, #6515, I need to get access to shard id and replica id through interface functions; and golang doesn't allow me to create ShardID() when there is a ShardID member variable. Also, changing it to private variables make it impossible for other classes to accidentally change shard id and replica id.
luluz66
added a commit
that referenced
this pull request
May 7, 2024
In replica.Replica, rename ShardID -> shardID and ReplicaID -> replicaID. In placement driver PR, #6515, I need to get access to shard id and replica id through interface functions; and golang doesn't allow me to create ShardID() when there is a ShardID member variable. Also, changing it to private variables make it impossible for other classes to accidentally change shard id and replica id.
luluz66
force-pushed
the
driver-prototype
branch
3 times, most recently
from
5e8eb1a
to
1d5be36
Compare
Some prototype code for placement driver. Tested locally for the following scenerio: - change the min replicas for a replica from 3 to 4; and see ranges got added to the 4th app.
luluz66
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Driver Queue that handles cases to up-replicate and replace dead replicas.
Implements a StoreMap, which is used by the DriverQueue to figure out which store is alive or dead.
Tested locally for the following scenarios:
added to the 4th app.
Related issues: N/A