Avoid sending task keepalive ping after stream is closed #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
task-leaser-check-closed
branch
from
288814a
to
f73c70c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #6507 which was closed.
There was no race condition in that original PR because we were holding a mutex before sending anything on the stream. However, there is a separate issue where
pingServercould potentially try to send a message on the stream afterClose()was called. In practice, this likely just adds noise to logs, but I figured it would be nice to fix.Also fix a small bug that the short-circuiting check in
Close()was not actually short-circuiting, though in practice we never actually hit this codepath because we only Close once.Related issues: N/A