Add remote bazel integration test #6411
Conversation
maggie-lou
force-pushed
the
rb_integration_test
branch
22 times, most recently
from
c4102a0
to
f737538
Compare
maggie-lou
force-pushed
the
rb_integration_test
branch
8 times, most recently
from
82fddff
to
fecc1a8
Compare
maggie-lou
force-pushed
the
rb_integration_test
branch
7 times, most recently
from
999f0eb
to
b529339
Compare
maggie-lou
changed the title
maggie-lou
force-pushed
the
rb_integration_test
branch
2 times, most recently
from
8db10f5
to
b9dcc8c
Compare
maggie-lou
force-pushed
the
rb_integration_test
branch
from
b9dcc8c
to
71684c8
Compare
maggie-lou
force-pushed
the
rb_integration_test
branch
2 times, most recently
from
0d1ce3f
to
3451788
Compare
enterprise/server/test/integration/remote_bazel/remote_bazel_test.go
Outdated
Show resolved
Hide resolved
| repoName := "private-test-repo" | ||
| username := "maggie-lou" |
There was a problem hiding this comment.
can you move this to the buildbuddy-io org?
There was a problem hiding this comment.
The repo is under the buildbuddy org, the token is under my account (you can't create a PAT for an org, but I could create a dummy account)
There was a problem hiding this comment.
Decided that it will probably be more annoying to track a password for a service account. Anyone can re-generate this PAT if they need, even if I leave the company and we can't access this token or something
| // This token grants read-only access to a private dummy repo. | ||
| // Github will invalidate tokens that are committed, so format it so that Github | ||
| // won't catch it. | ||
| personalAccessToken := fmt.Sprintf("github_pat_%s", "11ADKOFLI06Ob3cnrygcQa_gwLj0orOD3EILEu2k9pJ9EUkmXW6uM0k47k0uPOWInCDPHNC444JmQ8oN62") |
There was a problem hiding this comment.
I think we should avoid checking in access tokens, even though it only grants access to an empty repo - could you use the gh app token env var that is already passed to the workflow, so that this authenticates as the app installation rather than a person?
There was a problem hiding this comment.
Could you explain more what you're describing? This is a /buildbuddy repo test, so are you describing the /buildbuddy app token?
Also as a somewhat related note - I was playing around with accessing BB secrets from within a go test, and the only way I could get it to work was if I added --test_env=SECRET_NAME to the bazel command in buildbuddy.yaml. This passes the secret to all the tests, which may not be ideal (may be okay in this case, but could get messy if a lot of tests need to reference different secrets)
There was a problem hiding this comment.
Refactored to pull PAT from a secret (Also deleted the old PAT that was in our git history)
maggie-lou
force-pushed
the
rb_integration_test
branch
from
a1fa191
to
39c3138
Compare
… remote run completes
maggie-lou
force-pushed
the
rb_integration_test
branch
from
39c3138
to
946067e
Compare
maggie-lou
force-pushed
the
rb_integration_test
branch
from
946067e
to
faf6ffc
Compare
Related issues: N/A