Fix port race condition in distributed_test.FindMissing #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue affects only local runs. There's no guarantee that a port allocated by testport.FindFree() is still free by the time we try to listen on it and currently we silently swallow it which leads to unpredictable results. If you are happy with this approach, I will extend it to the other test cases as well. Part of addressing buildbuddy-io/buildbuddy-internal#3114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue affects only local runs. There's no guarantee that a port allocated by testport.FindFree() is still free by the time we try to listen on it and currently we silently swallow the listen error which leads to unpredictable results.
If you are happy with this approach, I will extend it to the other test cases as well.
Part of addressing https://github.com/buildbuddy-io/buildbuddy-internal/issues/3114
Related issues: N/A