Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch deprecation warning to error in BuildStepWrapperMixin #7609

Merged

Conversation

mokibit
Copy link
Collaborator

@mokibit mokibit commented May 14, 2024

This PR switches "Changes to attributes of a BuildStep instance" deprecation warning to config.error in BuildStepWrapperMixin.
PR is a partially addressing #7567.

  • I have updated the unit tests
  • [not_needed] I have created a file in the newsfragments directory (and read the README.txt in that directory)
  • [not_needed] I have updated the appropriate documentation

@mokibit mokibit force-pushed the convert-BuildStepWrapperMixin-warning-to-error branch from edb0420 to d9b4e1e Compare May 14, 2024 12:15
@p12tic p12tic merged commit 5ff602e into buildbot:master May 14, 2024
35 checks passed
@p12tic p12tic mentioned this pull request May 15, 2024
@mokibit mokibit deleted the convert-BuildStepWrapperMixin-warning-to-error branch May 15, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants