Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom prefix to KSCrash to avoid conflict, improve pod specification #77

Closed
wants to merge 4 commits into from

Conversation

kattrali
Copy link
Contributor

Changes

  • Updated KSCrash to latest upstream changes, applying Bugsnag's patches on top
  • Adds a Bugsnag prefix to vendored classes from KSCrash
  • Updated the podspec to use the new dependency as well as moving the target configuration to cocoapods-bugsnag, a cocoapods plugin.

Rationale

Until we/someone has the bandwidth to develop a solution to kstenerud/KSCrash#84, this change allows client applications to simultaneously use other libraries dependent on KSCrash. The namespacing is done via a script committed to a patch of KSCrash, and it finds and updates unprefixed classes as needed.

Fixes #41, #52, #72

@snmaynard
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use KSCrash dependency in CocoaPods instead of self-hosting
2 participants