Fix critical PHPCS issues #49

philcable · 2019-11-27T20:15:49Z

For 5.x upgrade preparation:

Fix unprepared SQL queries
Consolidate SQL query code to avoid false positives for unprepared statement
Replace local wp_redirect() calls with wp_safe_redirect()
Update post type name in order test to avoid use of reserved order post type

This also consolidates the statement to avoid a false positive for an unprepared SQL statement.

This also flags the false positive below the updated statement.

This also consolidates the query to avoid a false positive for an unprepared SQL statement.

This also follows the redirect with a call to `exit;`

The `$fields` variable probably needs some updated handling, too.

Not certain how necessary this change really is, as this is a test.

This is likely safe already, but it doesn't hurt to check.

philcable and others added 16 commits November 20, 2019 07:44

Add PHPCS configuration file

a02063f

Consolidate SQL query to avoid false positive for unprepared statement

e77f7de

Use a placeholder instead of interpolating $post->post_type

9f8be72

This also consolidates the statement to avoid a false positive for an unprepared SQL statement.

Use a placeholder instead of interpolating BU_NAVIGATION_LINK_POST_TYPE

62aaab7

This also consolidates the statement to avoid a false positive for an unprepared SQL statement.

Fix unprepared SQL statment

dad296a

This also flags the false positive below the updated statement.

Fix unprepared SQL statment

3d5f273

This also flags the false positive below the updated statement.

Fix unprepared SQL statment

8873cbc

This also flags the false positive below the updated statement.

Fix unprepared SQL statment

f298bb7

This also flags the false positive below the updated statement.

Consolidate SQL query to avoid false positive for unprepared statement

891ddd2

Fix unprepared SQL statement

5342138

Fix unprepared SQL statement

fb80364

This also consolidates the query to avoid a false positive for an unprepared SQL statement.

Use wp_safe_redirect() instead of wp_redirect()

01bfa69

This also follows the redirect with a call to `exit;`

Improve prepared queries

c9aea74

Fix unprepared SQL query in bu_navigation_get_posts() function

56c47d4

The `$fields` variable probably needs some updated handling, too.

Update test to avoid use of reserved post type order

4908f09

Not certain how necessary this change really is, as this is a test.

Pass filtered $field array through esc_sql() before using

b327444

This is likely safe already, but it doesn't hurt to check.

jeremyfelt approved these changes Jan 16, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix critical PHPCS issues #49

Fix critical PHPCS issues #49

philcable commented Nov 27, 2019 •

edited

Fix critical PHPCS issues #49

Are you sure you want to change the base?

Fix critical PHPCS issues #49

Conversation

philcable commented Nov 27, 2019 • edited

philcable commented Nov 27, 2019 •

edited