Design system and icon updates for 2.0 #5938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
iconography reference issue: #5485 |
|
Documenting as I work through everything. Might have more comments, will add them as I go. Few suggestions and nits:
|
dennisreimann
force-pushed
the
design
branch
2 times, most recently
from
ba87501
to
c2276b8
Compare
dennisreimann
force-pushed
the
design
branch
2 times, most recently
from
9a3e857
to
c73add9
Compare
|
This one is ready for now, let's try to integrate it soon. Can you give it a review, @dstrukt? |
NicolasDorier
approved these changes
May 15, 2024
|
Code ACK, didn't visually checked though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, will update this in an ongoing manner as we progress with 2.0 and the app.