Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow admin update default rate provider and default currency for stores #5918

Merged
merged 7 commits into from May 10, 2024

Conversation

TChukwuleta
Copy link
Contributor

@TChukwuleta TChukwuleta commented Apr 9, 2024

resolve #5653

Allow server admin can change currencies and providers for stores.

Cc. @dennisreimann

@dstrukt dstrukt self-requested a review April 10, 2024 04:37
@TChukwuleta
Copy link
Contributor Author

this is up for review :)

@NicolasDorier
Copy link
Member

NicolasDorier commented Apr 16, 2024

@TChukwuleta the idea isn't to give the admin the ability to change the config of individual stores.

The idea is to give the admin the ability to change what is selected by default in the "Create Store" wizard, so that new users don't have to select their currency and the right exchange manually.

It makes it possible for local admin to optimize the UX specifically for their local community.

@TChukwuleta
Copy link
Contributor Author

Oh. I see, thank you @NicolasDorier

@TChukwuleta
Copy link
Contributor Author

Hey @NicolasDorier I updated the policy section in server settings to give the admin the ability to update default currency, which is now used as default for create currency, and in scenarios where there is none, it selects the previous default USD (storeblob.defaultcurrency)

@NicolasDorier
Copy link
Member

Did a minor rewording of the label.

@NicolasDorier NicolasDorier merged commit 11b38a7 into btcpayserver:master May 10, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server admin can set up default rate provider and default currency for stores on the server
2 participants