Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refund reports #5791

Merged
merged 2 commits into from May 6, 2024
Merged

Conversation

NicolasDorier
Copy link
Member

@NicolasDorier NicolasDorier commented Feb 26, 2024

Refund reports.

I didn't see @Kukks has been working on it, possible alternative to #5783

Reviewed Kukks's one, outside a minor point (not using the display formatter), it's also good, no strong preferences.

image

Still need tests

@pavlenex
Copy link
Contributor

Unlike #5783, this one actually worked for me in dev enviroment.

@NicolasDorier Thoughts on giving crypto amount rate and currency? IMO these should reflect the typical payment report just do it for refunds and provide as much info as possible, you never know what people actually need from them.

Can you explain what fully paid status is? Is it full CryptoAmount or just complete refund or something else?

@NicolasDorier
Copy link
Member Author

@pavlenex Fully Paid is saying if all the money has been transferred from the pull payment of the refund.
We don't keep information on which way the user decided to reimburse. We only know he did a refund of X amount in X currency, which is all that is shown here.

That said, for BTCPay 2.0, we can start saving additional information for future refunds.

@NicolasDorier NicolasDorier added this to the 2.0.0 milestone Apr 19, 2024
@NicolasDorier NicolasDorier force-pushed the refundreport branch 2 times, most recently from 62b5441 to d4afe0e Compare April 19, 2024 05:34
@NicolasDorier
Copy link
Member Author

NicolasDorier commented Apr 19, 2024

This is now ready and tested. I changed the name of the columns to reflect what is used in the pull payments page.

Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have't tested in-depth.

@NicolasDorier NicolasDorier merged commit a89c0d4 into btcpayserver:master May 6, 2024
2 of 4 checks passed
@NicolasDorier NicolasDorier deleted the refundreport branch May 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of refunded invoice in invoices, invoice details and invoice export.
2 participants