Hi @Kukks , was advised that updating the export was the only thing remaining on this ticket. Found a couple items for clarification if you have time:

1. Refunds are list of Pull Payments. However, through the invoice detail page you can only perform a full or partial refund once. Should we anticipate multiple refunds in the future? Seems like we should.
2. If yes to 1, how should we deal with summing multiple refunds that may be in different currencies? Is there a function for this already? Easy solution would be to just take the first one but may cause problems in the future. But I guess we'd have to refactor in multiple areas anyway.
3. Paid and Paid Currency are strings but Invoice Due and Invoice Price are numbers. Thoughts? I'll leave as string for now (see draft).

Another separate-but-related issue:

• Export doesn't appear to go off of selected invoices but rather the search bar

@pavlenex

Need a little clarification for desired result -- invoice export actually can have multiple payments per invoice. Refunds have multiple pull payments per refund and could be added separately like payments. However, as @Kukks pointed out this is not really an invoice export now.

Some options:

1. Make this a top-level, invoice-only export (no multiple payments or pull payments)
2. Add pull payments, by line like we do for payments
3. Other

Also a separate issue to consider is that exporting invoices does not respect the checkbox selections -- it exports all invoices that have been listed on the page (via filter terms). Will try to join the call!

Update from dev call 7/19: We will go with option 2 -- listing all payments and pull payments

Hey @rustywave are you still up for tackling this one?

@pavlenex, sorry for being MIA! i won't be able to finish this or any others at this time. update is partway done but there are still some clarifications needed on which are the correct fields to use. i can either create a PR or push my changes to a remote branch for the next person to review.

If it helps, branch is here:
feature/3597-add-refund-to-invoice-export

Can delete if not needed anymore or just let me know and I'll delete.

The invoice export isn't an invoice export but a payment export. We shouldn't try to change the nature of it.

If we need exports on other things, we need more discussion and refactor completely our data export system.
It isn't an easy topic as there are multiple use cases to consider, and it is never clear for each use case which fields and data would make sense.

But would be to inspire from fireflyiii.

This shouldn't go in 1.7.0

@NicolasDorier Agreed. Can you explain what fireflyiii does that you like?