Make tests work with environment secrets. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extending Invoice Client and Result classes * Health and Invoice Tests * Removed isPaid * Move requiresRefundEmail to bottom with default value
* LightningStore Client Test Suite * Renames getInvoice to getLightningInvoice * Adds amount, maxFeePercent and maxFeeFlat to payLightningInvoice
* Miscellaneous Client Test Suite * InvoiceCheckoutHtml Result Class + Test
* Notification Tests
|
Seems PRs from forked repos have no secrets available for security reasons (see https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/) . There seems to be a pull_request_target event that triggers then the workflow on the current master branch and not on the forked code as far as I understand. Defeats a bit the purpose so we might need another solution |
|
I would suggest we just remove phpunit test from github actions, and maybe make a policy that all PRs need to include a screenshot of passing tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While repository secrets work on my own fork of this repo it seems that they don't for non-admin users on pull requests as they could leak confidential data on running the workflows. Also in every case $_ENV is empty because of PHP config,
getenv()works though.