Add lnbits

[petzsch]

⚠️This pull request is a work in progress.
⚠️Warning: There are still many moving parts in this PR, test at your own risk and please don't use for production setups!

If you want to support the testing of this PR, you can check it out following:

1. cd /root/BTCPayServer/btcpayserver-docker/ (or where you orginallly checked out the btcpayserver-docker repo)
2. git remote set-url origin https://github.com/petzsch/btcpayserver-docker.git
3. git pull
4. git checkout add-lnbits
5. follow the docs: here.

TODOs:

• fix the retry issue (will be fixed in 0.12.8 docker image)
• create lnbits-configure.sh script (move env vars in docker file, create config wizard etc.)
• more testing
• mergen branch test-lnbits-0.12.8 into this one
• C-Lightning switched to clightning-rpc for 0.1.2.8 until lnbits supports CLNRest: Add support for the new CLNRest as a funding source so that runes can be used to give LNBits limited access to the lightning node lnbits/lnbits#2232
• figure out the implications of not having AUTH_SECRET_KEY configured or howto do it the proper way

[PatMulligan]

add after line 171?
* [opt-add-lnbits](docker-compose-generator/docker-fragments/opt-add-lnbits.yml), for a self-hosted lnbits backed by BTCPay Server.

[petzsch]

add after line 171? * [opt-add-lnbits](docker-compose-generator/docker-fragments/opt-add-lnbits.yml), for a self-hosted lnbits backed by BTCPay Server.

Thanks for pointing this out. I've added your suggestion.

[Meisterzunge]

When does this feature will be approved? Cant wait for it 🙃

[Kukks]

I'm reluctant to approve this because there are many steps to get this working right and most users might shoot themselves in the foot and cause the need for troubleshooting.

I don't have a suggestion either. But I'm hoping this becomes a much simpler setup in terms of what a user needs to do on a terminal

[petzsch]

What bugs me currently: When a user makes modifications to their .env file for lnbits, and we add stuff there by an update - it will run into a merge conflict.

Thats one of the points where I see the need of support.

Don't see a better option then documenting those cases so that users can help themselves.

What would be nice: Not to need a seperate sub-/domain but let this run inside the BTCPay vHost. Which I think you discovered would need a lot of changes from lnbits end.

Question remains: Do we keep this PR open and keep on merging master and lnbits updates into it? How about recommending it to people at all? Just for test setups currently?

Thanks for taking the time to look at this. @Kukks

[Kukks]

What bugs me currently: When a user makes modifications to their .env file for lnbits, and we add stuff there by an update - it will run into a merge conflict.

Thats one of the points where I see the need of support.

Don't see a better option then documenting those cases so that users can help themselves.

What would be nice: Not to need a seperate sub-/domain but let this run inside the BTCPay vHost. Which I think you discovered would need a lot of changes from lnbits end.

Question remains: Do we keep this PR open and keep on merging master and lnbits updates into it? How about recommending it to people at all? Just for test setups currently?

Thanks for taking the time to look at this. @Kukks

maybe you can write some automation scripts? like lnbits-configure.sh which acts as a wizard?

[petzsch]

I will think some more about it. I thought about replacing the .env file from lnbits with actual environment variables set in the dockerfile. Maybe the lnbits-configure.sh script could:

1. ask for the desired sub/domain -> set the env variable and run btcpay-setup.sh at the end.
2. create the database if not already existant
3. create a opt-add-lnbits.custom.yml with environment values for stuff like the admin user id, and/or actual user ids to lock down new registrations (only shown if the user table exists in lnbits already, i.e. on second run of the script)

any additions?

[Kukks]

I will think some more about it. I thought about replacing the .env file from lnbits with actual environment variables set in the dockerfile. Maybe the lnbits-configure.sh script could:

1. ask for the desired sub/domain -> set the env variable and run btcpay-setup.sh at the end.
2. create the database if not already existant
3. create a opt-add-lnbits.custom.yml with environment values for stuff like the admin user id, and/or actual user ids to lock down new registrations (only shown if the user table exists in lnbits already, i.e. on second run of the script)

any additions?

You'll need to check about the db container (if it exists to create the db first), and maybe even to configure based on LN node used?

[petzsch]

pushed lnbits 0.12.8 to this branch.

Configuration no longer happens via the .env files, but via environment variables that are set for LND or Clightning and can be overwritten with custom fragments.

example for a custom fragment:

opt-add-lnbits-admin.custom.yml

version: '3'

services:
  lnbits:
    environment:
      LNBITS_ALLOWED_USERS: USER-ID-FROM-USER-PROFILE-PAGE
      LNBITS_ADMIN_USERS: USER-ID-FROM-USER-PROFILE-PAGE