C-Lightning REST: Enable access to all RPC commands #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C-Lightning REST project allows access to all additional CLightning RPC commands by default: https://github.com/Ride-The-Lightning/c-lightning-REST#rpc BTCPayServer-docker currently ships with this option disabled. However many useful RPC commands have not been wrapped by the REST project yet, so it is convenient to enable these by default.
|
why did you close this? |
|
Just doing some more testing on it first, the pull request was a bit early. It seems to work for "no-parameter" rpc calls, but not for calls with parameters. Will re-open when I have some more information though. |
|
Maybe you can help! Actually yeah the problem seems to be that BTCPayServer won't accept parameters in the request body (as JSON), which is what is necessary to use this endpoint... any idea where that can be configured? Adding them as request parameters doesn't seem to be an option, it's expecting an array or object, and doesn't seem to parse it as a string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C-Lightning REST project allows access to all additional CLightning RPC commands by default: https://github.com/Ride-The-Lightning/c-lightning-REST#rpc
BTCPayServer-docker currently ships with this option disabled. However many useful RPC commands have not been wrapped by the REST project yet, so it is convenient to enable these by default.