Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE AFTER 2.0] Remove docs on customizing checkout page #1385

Merged
merged 6 commits into from May 6, 2024

Conversation

TChukwuleta
Copy link
Contributor

Based on the BTCPay Server 2.0: Megathread , part of the task is to Remove docs on https://docs.btcpayserver.org/Development/Theme/#checkout-page-themes

This PR tends to resolve it, by removing the path from the side bar so that it is not accessible

@NicolasDorier
Copy link
Member

NicolasDorier commented Apr 7, 2024

Why not removing the article itself and the images as well?

Also note: To be merged when 2.0 is out.

@TChukwuleta
Copy link
Contributor Author

I wasn't sure so sure, that's why I didn't remove it. I would do that.

Yea, I'm aware that it's after 2.0 merge. Thank you

Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should completely remove the page, but most of it. We should keep the "Developing and extending a custom theme" part and adapt it to what we've added with the branding options.

Can you re-add that page with the "Developing and extending a custom theme" only (until "2. Bootstrap themes") and I can adjust it from there? Thanks!

@TChukwuleta
Copy link
Contributor Author

Sure @dennisreimann

@TChukwuleta
Copy link
Contributor Author

Updated @dennisreimann

Copy link
Member

@dennisreimann dennisreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted it to fit with the current state.

@pavlenex
Copy link
Contributor

To be merged when 2.0 is out.

@pavlenex pavlenex changed the title Remove docs on customizing checkout page [MERGE AFTER 2.0] Remove docs on customizing checkout page Apr 30, 2024
@pavlenex
Copy link
Contributor

pavlenex commented May 2, 2024

@dennisreimann mentioned

The doc in the PR version is a refresher about customizing the server theme, imho it can get merged right away.

I agree with this, @NicolasDorier ?

@NicolasDorier
Copy link
Member

Seems good to me

@pavlenex pavlenex merged commit 1d9df2a into btcpayserver:master May 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants