Resolving a problem that seems to be associated with the introduction… #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of AutoMie_ab into the MieS1S2 routine. Looking at the code for AutoMie_ab there is a hard crossover and this seems to have introduced the problem. There is also a check for a crossover in both MieQ and AutoMieQ which could cause a conflict. I have introduced a module wide variable called crossover and given it a value of 0.01. I have removed the crossover parameter from the AutoMieQ function call. I now use the module wide parameter to test for crossover in AutoMieQ and AutoMie_ab I have removed the crossover check in MieQ and left the full Mie expansion. The user is now able to change the crossover value him or herself. import PyMieScatt.Mie as Mie Mie.crossover = 0.001 This allows the use some control over the crossover if they are unhappy with the default setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of AutoMie_ab into the MieS1S2 routine.
Looking at the code for AutoMie_ab there is a hard crossover and this seems to have introduced the problem.
There is also a check for a crossover in both MieQ and AutoMieQ which could cause a conflict.
I have introduced a module wide variable called crossover and given it a value of 0.01.
I have removed the crossover parameter from the AutoMieQ function call.
I now use the module wide parameter to test for crossover in AutoMieQ and AutoMie_ab
I have removed the crossover check in MieQ and left the full Mie expansion.
The user is now able to change the crossover value him or herself.
import PyMieScatt.Mie as Mie
Mie.crossover = 0.001
This allows the use some control over the crossover if they are unhappy with the default setting.