Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tooltips to sidebar. Removed label_information references #159

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added tooltips to sidebar. Removed label_information references #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
761d51d
Added tooltips to sidebar. Removed label_information references
xhruso00 Jan 25, 2016
5df1613
Added missing IBOutlet keyword
xhruso00 Jan 25, 2016
9b41583
Reverted changes in toolbarLabel. Imporved sidebar with bindings. Imp…
xhruso00 Jan 29, 2016
18657b3
Removed some unused sidebar code
xhruso00 Jan 29, 2016
24682e6
Added BPRepository into model. Updated code to reflect this change
xhruso00 Jan 30, 2016
e2aae4b
Changed parsing of outdated formulas
xhruso00 Jan 31, 2016
8824ebd
Fixing missing version
xhruso00 Jan 31, 2016
247309a
Two array controllers with single backing array added. Added builder …
xhruso00 Feb 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions Cakebrew.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
D2A3A82E1B8C9F5200D05469 /* BPStyle.m in Sources */ = {isa = PBXBuildFile; fileRef = D2A3A82A1B8C9F5200D05469 /* BPStyle.m */; };
D2A3A82F1B8C9F5200D05469 /* BPUtilities.m in Sources */ = {isa = PBXBuildFile; fileRef = D2A3A82C1B8C9F5200D05469 /* BPUtilities.m */; };
D2A3A8301B8C9F5200D05469 /* BPUtilities.m in Sources */ = {isa = PBXBuildFile; fileRef = D2A3A82C1B8C9F5200D05469 /* BPUtilities.m */; };
D2A406381C5BBB4900A76548 /* BPRepository.m in Sources */ = {isa = PBXBuildFile; fileRef = D2A406371C5BBB4900A76548 /* BPRepository.m */; };
D2B3A3AA19B9CBEC00DE23B5 /* BPFormulaeTableView.m in Sources */ = {isa = PBXBuildFile; fileRef = D2B3A3A919B9CBEC00DE23B5 /* BPFormulaeTableView.m */; };
D2B3A3B019B9D7FC00DE23B5 /* BPFormulaeDataSource.m in Sources */ = {isa = PBXBuildFile; fileRef = D2B3A3AF19B9D7FC00DE23B5 /* BPFormulaeDataSource.m */; };
D2BBAB4B1B85EA7C00F21332 /* BPFormulaOption.m in Sources */ = {isa = PBXBuildFile; fileRef = D2BBAB4A1B85EA7C00F21332 /* BPFormulaOption.m */; };
D2BBAB4E1B863FAB00F21332 /* BPFormulaOption.m in Sources */ = {isa = PBXBuildFile; fileRef = D2BBAB4A1B85EA7C00F21332 /* BPFormulaOption.m */; };
D2BBAB681B87142F00F21332 /* brewInfo_acme.txt in Resources */ = {isa = PBXBuildFile; fileRef = D2BBAB621B87142F00F21332 /* brewInfo_acme.txt */; };
Expand Down Expand Up @@ -209,10 +209,10 @@
D2A3A82A1B8C9F5200D05469 /* BPStyle.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BPStyle.m; sourceTree = "<group>"; };
D2A3A82B1B8C9F5200D05469 /* BPUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BPUtilities.h; sourceTree = "<group>"; };
D2A3A82C1B8C9F5200D05469 /* BPUtilities.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BPUtilities.m; sourceTree = "<group>"; };
D2A406361C5BBB4900A76548 /* BPRepository.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BPRepository.h; sourceTree = "<group>"; };
D2A406371C5BBB4900A76548 /* BPRepository.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BPRepository.m; sourceTree = "<group>"; };
D2B3A3A819B9CBEC00DE23B5 /* BPFormulaeTableView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BPFormulaeTableView.h; sourceTree = "<group>"; };
D2B3A3A919B9CBEC00DE23B5 /* BPFormulaeTableView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BPFormulaeTableView.m; sourceTree = "<group>"; };
D2B3A3AE19B9D7FC00DE23B5 /* BPFormulaeDataSource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BPFormulaeDataSource.h; sourceTree = "<group>"; };
D2B3A3AF19B9D7FC00DE23B5 /* BPFormulaeDataSource.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BPFormulaeDataSource.m; sourceTree = "<group>"; };
D2BBAB491B85EA7C00F21332 /* BPFormulaOption.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = BPFormulaOption.h; path = Models/BPFormulaOption.h; sourceTree = "<group>"; };
D2BBAB4A1B85EA7C00F21332 /* BPFormulaOption.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = BPFormulaOption.m; path = Models/BPFormulaOption.m; sourceTree = "<group>"; };
D2BBAB621B87142F00F21332 /* brewInfo_acme.txt */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = brewInfo_acme.txt; sourceTree = "<group>"; };
Expand Down Expand Up @@ -297,8 +297,6 @@
15D28A191AE332E6005C8A3E /* BPDoctorView.xib */,
150AEC381B3F999A00163767 /* BPDoctorViewController.h */,
150AEC391B3F999A00163767 /* BPDoctorViewController.m */,
D2B3A3AE19B9D7FC00DE23B5 /* BPFormulaeDataSource.h */,
D2B3A3AF19B9D7FC00DE23B5 /* BPFormulaeDataSource.m */,
15D28A1C1AE332EA005C8A3E /* BPFormulaOptionsWindow.xib */,
150AEC3A1B3F999A00163767 /* BPFormulaOptionsWindowController.h */,
150AEC3B1B3F999A00163767 /* BPFormulaOptionsWindowController.m */,
Expand Down Expand Up @@ -388,6 +386,8 @@
D2BBAB4A1B85EA7C00F21332 /* BPFormulaOption.m */,
1570BA5418EE50BD001C3C5C /* BPFormula.h */,
1570BA5518EE50BD001C3C5C /* BPFormula.m */,
D2A406361C5BBB4900A76548 /* BPRepository.h */,
D2A406371C5BBB4900A76548 /* BPRepository.m */,
);
name = Models;
sourceTree = "<group>";
Expand Down Expand Up @@ -683,6 +683,7 @@
150AEC531B3F999A00163767 /* BPSelectedFormulaViewController.m in Sources */,
150AEC541B3F999A00163767 /* BPSideBarController.m in Sources */,
1570BA5618EE50BD001C3C5C /* BPFormula.m in Sources */,
D2A406381C5BBB4900A76548 /* BPRepository.m in Sources */,
15CEFC631AB335B2005CF54A /* BPLoadingView.m in Sources */,
D2C4278B1B8E055B001C1F80 /* BPDisabledView.m in Sources */,
1FE4FE65148E4CDD008EDE8B /* main.m in Sources */,
Expand All @@ -697,7 +698,6 @@
D23620E11B8B3094006D293D /* BPTask.m in Sources */,
15C34CBF19512DE100B92E36 /* BPAutoScrollTextView.m in Sources */,
150AEC4F1B3F999A00163767 /* BPHomebrewViewController.m in Sources */,
D2B3A3B019B9D7FC00DE23B5 /* BPFormulaeDataSource.m in Sources */,
D2F732F119190B75002B2512 /* NSString+URLValidation.m in Sources */,
15D2CFAB18F202B300B6D9F1 /* DCOAboutWindowController.m in Sources */,
D2A3A82D1B8C9F5200D05469 /* BPStyle.m in Sources */,
Expand Down
21 changes: 0 additions & 21 deletions Cakebrew/BPFormulaeDataSource.h
View file
Open in desktop

This file was deleted.

145 changes: 0 additions & 145 deletions Cakebrew/BPFormulaeDataSource.m
View file
Open in desktop

This file was deleted.

24 changes: 3 additions & 21 deletions Cakebrew/BPFormulaeTableView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,8 @@ - (void)configureTableForListing
break;

case kBPListInstalled:
titleWidth = (NSInteger)(totalWidth * 0.4);
[[self tableColumnWithIdentifier:kColumnIdentifierVersion] setHidden:NO];
[[self tableColumnWithIdentifier:kColumnIdentifierVersion] setWidth:(totalWidth-titleWidth)*0.95];
titleWidth = (NSInteger)(totalWidth * 0.99);
[[self tableColumnWithIdentifier:kColumnIdentifierVersion] setHidden:YES];
[[self tableColumnWithIdentifier:kColumnIdentifierLatestVersion] setHidden:YES];
[[self tableColumnWithIdentifier:kColumnIdentifierStatus] setHidden:YES];
[self setAllowsMultipleSelection:NO];
Expand All @@ -78,24 +77,7 @@ - (void)configureTableForListing
[[self tableColumnWithIdentifier:kColumnIdentifierStatus] setHidden:YES];
[self setAllowsMultipleSelection:YES];
break;

case kBPListSearch:
titleWidth = (NSInteger)(totalWidth - 90);
[[self tableColumnWithIdentifier:kColumnIdentifierVersion] setHidden:YES];
[[self tableColumnWithIdentifier:kColumnIdentifierLatestVersion] setHidden:YES];
[[self tableColumnWithIdentifier:kColumnIdentifierStatus] setHidden:NO];
[[self tableColumnWithIdentifier:kColumnIdentifierStatus] setWidth:(totalWidth-titleWidth)*0.90];
[self setAllowsMultipleSelection:NO];
break;

case kBPListRepositories:
titleWidth = (NSInteger)(totalWidth * 0.99);
[[self tableColumnWithIdentifier:kColumnIdentifierVersion] setHidden:YES];
[[self tableColumnWithIdentifier:kColumnIdentifierLatestVersion] setHidden:YES];
[[self tableColumnWithIdentifier:kColumnIdentifierStatus] setHidden:YES];
[self setAllowsMultipleSelection:NO];
break;


default:
break;
}
Expand Down
3 changes: 1 addition & 2 deletions Cakebrew/BPHomebrewInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ typedef NS_ENUM(NSInteger, BPListMode) {
kBPListInstalled,
kBPListLeaves,
kBPListOutdated,
kBPListSearch, /* Don't call -[BPHomebrewInterface listMode:] with this parameter. */
kBPListRepositories
};

Expand Down Expand Up @@ -154,7 +153,7 @@ typedef NS_ENUM(NSInteger, BPListMode) {
*
* @return List of BPFormula objects.
*/
- (NSArray*)listMode:(BPListMode)mode;
- (NSMutableArray *)listMode:(BPListMode)mode;

/**
* Executes `brew info` for parameter formula name.
Expand Down