This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
Make sure element is connected to DOM before element.setVisible() #1304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Browser.html home page, this
element.setVisible()
raises an error below:It calls this
visibility()
with the pageiframe
as theelement
.But at the very first time, the
iframe
looks newly created and out of DOM tree;And it turns out to fail
element.setVisible()
and raise the exception.So fixed to check
element
is surely underdocument
beforeelement.setVisible()
.Otherwise, skip it.
With this fix, each element's first call of
visibility()
is ignored.But such brand-new element should be visible and it does not make any problem, I think.
Check environment is below:
http://
user_pref("dom.mozBrowserFramesEnabledForContent", true);
in user.js in profile.