New feature: creating a directory tree #1367
Conversation
|
WHOA. What does this do in the browser? |
|
Nothing -- it's in the filelib module, which isn't made available on CPO. |
| if (isISD(tree)) { | ||
| RUNTIME.ffi.toArray(RUNTIME.getField(tree, "keys-list").app()).forEach(function(sub) { | ||
| var kid = RUNTIME.getColonField(tree, "get-value").full_meth(tree, sub); | ||
| makeDirs(baseDir + "/" + sub, kid); |
There was a problem hiding this comment.
Should we be more judicious about using path.join or whatever the blessed path library thing is? I know we have other windows issues but that's probably the right thing to do.
There was a problem hiding this comment.
I can't tell, tbh: https://nodejs.org/docs/latest/api/fs.html#fsmkdirpath-options-callback gives an example of calling mkdir on "/" even on Windows...
| if (!fs.existsSync(baseDir)) fs.mkdirSync(baseDir); | ||
| if (isISD(tree)) { | ||
| RUNTIME.ffi.toArray(RUNTIME.getField(tree, "keys-list").app()).forEach(function(sub) { | ||
| var kid = RUNTIME.getColonField(tree, "get-value").full_meth(tree, sub); |
There was a problem hiding this comment.
Maybe worth a comment that this won't stack capture because of what we know about immutable-string-dict's get-value method being flat? Like if this was changed to a generic .get-value dictionary interface, this wouldn't be safe.
Implements a new method
create-dir-tree, which is likemkdir -pbut enhanced. Given a base directory, and a string-dict of string-dicts of ..., where the innermost string-dicts' values are irrelevant, build a directory tree whose nesting structure corresponds to the keys of the string-dicts.