Added roughnum tokens that allow optional trailing ellipses (before e… #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xponent if any). fromString() recognizes such roughnums. Added a whole bunch of bad number tokens to catch illegal dots or incorrect number of dots. DefaultReprMethods.number prints roughnums with '...'. Add roughnum method toStringDots() that prints roughnum with '...'. Added lexing error checks for illegal numbers involving ellipses. Added parsing-error checks for bad numbers.
|
@ds26gte I don't think it was a permission issue – I think Github just won't let a PR be created if there's another PR of the same commit already existing (I just saw a link to the cross-repo PR when I looked at the branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1071.
Differences are:
The optional ellipsis is placed before the exponent for such roughnums as are in scientific notation.
pyret-tokenizer.js adds many regexps that are recognizably bad numbers, involving illegal dots, or incorrect number of dots. Tests for these are included in parse.js and test-parse-errors.arr.
Note that bad numbers of the type 2. and ~2. are not treated as bad numbers as they're currently treated as methods called on a non-object.