-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: type: module
#471
Merged
Merged
ref: type: module
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 48a7c04): https://ccv-honeycomb--pr471-type-module-28cnc5nr.web.app (expires Thu, 23 May 2024 19:22:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
Removes the renderer.js file
RobertGemmaJr
added
the
4.0
Versioning: Issue in regards to version 4.0.0 release
label
May 14, 2024
broarr
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I love modules
build: Remove uneeded depencies
fix: Fix window differences beteem dev and prod
fix: Add serialport code as its own file again
…into type-module
BREAKING CHANGE: Update data paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: module
to the package.jsonforge.config.js
and.prettierrc.js
to be ES Modulesrenderer.js
file, theindex.html
loadsindex.jsx
directlyVite Builds
I've been able to dig into how the Electron forge plugin is working with the Vite configurations. Basically the
config
section of"@electron-forge/plugin-vite"
the basic configuration for vite, whichvite.__.config.js
override.forge.config.js
is where we pass in the Electron files to be built and the specific vite configs handle the core of the building process.The big takeaway is that, even though Vite handles the ESM format, electron-forge builds the app as CJS. All I really had to do was update the file extensions to specify CJS and vite runs the built files correctly. Obviously I would like the files to be built to ESM but that seems to be blocked by the
electron-forge
plugin itself.