added the ability to pass advanced options to the request (like timeout…) #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bafio Is there an eta on when this will be merged/available? |
|
@rdhanoa I have no write privileges on this repo, @brooklynDev may be able to answer your question |
|
@brooklynDev Are there any chance that this PR will be accepted? |
|
@mycargus thoughts? |
|
I'll take a look. I like the idea for sure. |
|
finally diving into this today. Sorry for the delay. |
|
+1 This looks good to me, though I think some additional integration tests would be nice to verify the options work as expected and aren't just sent to the RestClient library. Not a blocker though in my opinion. Looks like we just have some merge conflicts to iron out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the ability to pass advanced options to the request (like timeout…)