Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias default url #1530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

marcolgl
Copy link

Hi,
this PR addresses the need for a default url to replace the one
specified when creating an alias, when no input is given to the
omnibar other than the alias.
This feature, which i miss from vimiumc, is to set an url for
those site for which you want an alias, but also redirect to
another url (e.g. an homepage) when you don't provide a
result to search for.
I implemented that as an user setting, to avoid changes to
the already crowded signature of addSearchAlias :

addAliasDefaultUrl(alias, default_url)

where alias must be a defined alias.
Thanks for your consideration and for your work

surfingkeys-demo.mp4

it let you define the default url for an alias when you provide
blank input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant